-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127251/
-----------------------------------------------------------
(Updated März 2, 2016, 12:48 vorm.)
Review request for KDE Frameworks and Vishesh Handa.
Bugs: 345750
https://bugs.kde.org/show_bug.cgi?id=345750
Repository: kunitconversion
Description
-------
QNetworkReply does not implement waitForReadyRead
Also, the code never actually created the cache dir it was trying to create a
file in.
Diffs
-----
src/currency.cpp 3b99644
Diff: https://git.reviewboard.kde.org/r/127251/diff/
Testing (updated)
-------
Works now. It's downloaded once and then taken from cache file in
~/.local/share/libkunitconversion/currency.xml
Given it's a Tier 2 framework doesn't make sense to add KIO now, also failed to
reproduce the crashes mentioned in the code.
Tests pass (only if I run them on English locale btw)
Obviously not happy with this being sync but alas that's how the API works.
Not sure if this is a KRunner bug or KUnitConverison but if I enter "5 USD" it
converts fine, if I enter "5 usd" it returns zero for all the currencies it
converted to.
Thanks,
Kai Uwe Broulik
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
