----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/#review93073 -----------------------------------------------------------
Looks good to me. I'd prefer inline noop functions to macros, but I don't really mind. src/lib/util/kuser_unix.cpp (line 68) <https://git.reviewboard.kde.org/r/127205/#comment63467> I'd change this to `__BIONIC__` too - Alex Richardson On March 1, 2016, 9:38 p.m., Andreas Cord-Landwehr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127205/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 9:38 p.m.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez and Alex Richardson. > > > Repository: kcoreaddons > > > Description > ------- > > Android's libc implementation lacks several features required by the Unix > backend implementation. This patch allows compilation by adding stubs for all > missing struct members and functions. Result of this patch is that on Android > KUser returns empty GUID and UID lists. > > > Diffs > ----- > > CMakeLists.txt da67071 > src/lib/CMakeLists.txt cf57f09 > src/lib/util/kuser_unix.cpp de5acde > > Diff: https://git.reviewboard.kde.org/r/127205/diff/ > > > Testing > ------- > > Compilation tested on Linux and Android. > > > Thanks, > > Andreas Cord-Landwehr > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
