----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/ -----------------------------------------------------------
(Updated March 7, 2016, 8:38 p.m.) Review request for KDE Frameworks and Gregor Mi. Changes ------- It is not related to DBus (Just Windows ;) Added comments and a nullptr check before adding a the pointer to the kmtServiceList Summary (updated) ----------------- Fix crash in kmore tools on Windows Repository: knewstuff Description (updated) ------- On Windows we sometimes get null-pointers in stead of pointers to KMoreToolsService. This patch adds checks for null-pointers in those places that made Kate crash in the project plugin and adds a nullptr check before adding them to the list. Diffs (updated) ----- src/kmoretools/kmoretoolsmenufactory.cpp 30f4d02 src/kmoretools/kmoretoolspresets.cpp 2405321 Diff: https://git.reviewboard.kde.org/r/127237/diff/ Testing (updated) ------- Compiled and run on windows. No crashes in Kate when right-clicking files in the project plugin. Thanks, Kåre Särs
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
