----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127326/#review93387 -----------------------------------------------------------
Can you please explain clearly the problem this should solve and explain more clearly how this solves that problem? Also I see with your every review "I have not tested this", please do test your patches before posting them. - Martin Klapetek On March 10, 2016, 10:28 a.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127326/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 10:28 a.m.) > > > Review request for KDE Frameworks, Kai Uwe Broulik, David Edmundson, and > Martin Klapetek. > > > Repository: knotifications > > > Description > ------- > > If KNotification is not notified, he don't ref() notification, if call > close() on it cause a leak, emu closed() is not triggered. > https://git.reviewboard.kde.org/r/127318/ > > > Diffs > ----- > > src/knotification.cpp 17b0be2 > > Diff: https://git.reviewboard.kde.org/r/127326/diff/ > > > Testing > ------- > > No real test, just blame me if i'm not right. > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
