----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127398/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: knotifications Description ------- Adds basic set of unit tests including fake notifications server. This helped uncover and fix these issues: * Calling close() on KNotification that was not "sent" would not emit closed() and would not delete it * Closing a notification can delete the KNotification object prematurely * Invoking an action leads to unnecessary dbus roundtrip * Invoking an action would fail to properly close and delete the KNotification object Diffs ----- CMakeLists.txt 6d09051 autotests/CMakeLists.txt PRE-CREATION autotests/fake_notifications_server.h PRE-CREATION autotests/fake_notifications_server.cpp PRE-CREATION autotests/knotification_test.cpp PRE-CREATION autotests/knotifications5/qttest.notifyrc PRE-CREATION autotests/qtest_dbus.h PRE-CREATION src/knotification.cpp 17b0be2 src/knotificationmanager.cpp e80d48c src/knotificationplugin.cpp acf964c src/notifybypopup.cpp b9489c1 Diff: https://git.reviewboard.kde.org/r/127398/diff/ Testing ------- Unit tests all pass. Thanks, Martin Klapetek
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
