----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127606/#review94636 -----------------------------------------------------------
Ship it! Ship It! - Kai Uwe Broulik On April 7, 2016, 10:27 nachm., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127606/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 10:27 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kunitconversion > > > Description > ------- > > If we can't download a conversion rate for a currency, return > value.isValid() == false. > > Current code had some based on the exchange rates of 2013. In many other > cases it would be multiplied by a few billion. > > > Diffs > ----- > > autotests/valuetest.h 645b0618a14a0e1e143e02301fbbddfb4539a238 > autotests/valuetest.cpp a45fd1755b51c88b896b0a17b335ae99dd391c11 > src/currency.cpp 3b99644a4d32433c074080ab91d92466a6ccc3a9 > src/value.cpp ec068f871975a2f7b8fd31d8481cc662d13a6fb8 > > Diff: https://git.reviewboard.kde.org/r/127606/diff/ > > > Testing > ------- > > Ran krunner whilst not connected and the cache file deleted. Got no results > rather than bogus results. > (Requires an additional one liner in the conversion runner to check result > validity) > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
