> On April 25, 2016, 1:55 p.m., Martin Gräßlin wrote: > > The change looks wrong to me. The functionality of that poller > > implementation is not bound to the availability of the dbus interface, but > > on the XScreenSaver X11 extension. The dbus interface is only used to emit > > a resumeFromIdle when the screen saver deactivated. > > Paulo Lieuthier wrote: > > The dbus interface is only used to emit a resumeFromIdle when the > screen saver deactivated. > > And is it okay if that doesn't work as expected?
given the API documentation I would say yes, that's OK: "Triggered, if KIdleTime is catching resume events, when the system resumes from an idle state." >From that I don't read that it must emit this signal. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127699/#review94832 ----------------------------------------------------------- On April 20, 2016, 6:54 p.m., Paulo Lieuthier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127699/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 6:54 p.m.) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Repository: kidletime > > > Description > ------- > > If the dbus interface org.freedesktop.ScreenSaver is not present, it makes no > sense to use the plugin. > > > Diffs > ----- > > src/plugins/xscreensaver/xscreensaverbasedpoller.h 05b9a23 > src/plugins/xscreensaver/xscreensaverbasedpoller.cpp f56396c > src/widgetbasedpoller.h 68fc7dc > > Diff: https://git.reviewboard.kde.org/r/127699/diff/ > > > Testing > ------- > > Tested minimal application using KIdleTime using the xscreensaver plugin. > > > Thanks, > > Paulo Lieuthier > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
