> On April 27, 2016, 9:03 p.m., Albert Astals Cid wrote: > > Question: Do we care if the contents of those files changes on runtime? > > I.e. do we want to get the updated values?
I would think so, this is going to break style/palette changes being loaded in frameworks integration that uses the app config. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127765/#review94917 ----------------------------------------------------------- On April 27, 2016, 4:14 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127765/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 4:14 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > A next step for my little quest is improving KConfig impact upon start. > > In callgrind terms, 20% of dolphin's startup time is KConfig and 15% is > parsing global files, which is essentially loading kdeglobals 70 times. This > of course also means that kdeglobals is scattered 70 times in each > application's memory space. > > To improve such situation, here's an attempt to cache these. I'm not an > expert in KConfig, so feedback is really appreciated > [[1]](http://i1.kym-cdn.com/photos/images/facebook/000/234/765/b7e.jpg) > > > Diffs > ----- > > src/core/kconfig.cpp ad52da9 > > Diff: https://git.reviewboard.kde.org/r/127765/diff/ > > > Testing > ------- > > Tests pass, KConfig becomes 6% of dolphin at load. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
