----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/ -----------------------------------------------------------
(Updated May 4, 2016, 2:47 p.m.) Review request for KDE Frameworks, Alex Richardson and Michael Pyne. Changes ------- turned tests for applicationData into separate test unit and made one test, also moved helper method into anonymous namespace Repository: kcoreaddons Description ------- There is code in e.g. KXMLGUI which relies on KAboutData::applicationData(), without requiring the user to use KAboutData::setApplicationData(). So better be complete when initializing the data from the Q*Application metadata. Also - warn if there is no Q*App instance yet to set properties in KAboutData::setApplicationData - check and warn if KAboutData::applicationData is out-of-sync with qapp data - remove bogus check for empty display name, as the method defaults to componentname - unit tests KAboutDataTest::testSetOfQApplicationData/testPickupOfQApplicationData Diffs (updated) ----- autotests/CMakeLists.txt a7a6752 autotests/kaboutdataapplicationdatatest.cpp PRE-CREATION src/lib/kaboutdata.h 97c0f2b src/lib/kaboutdata.cpp ceb0c06 Diff: https://git.reviewboard.kde.org/r/127655/diff/ Testing ------- Added autotests pass. Thanks, Friedrich W. H. Kossebau
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
