----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127829/#review95167 -----------------------------------------------------------
src/knotifyconfigactionswidget.cpp (line 137) <https://git.reviewboard.kde.org/r/127829/#comment64584> maybe `soundFilename.contains(':')` would do the trick? This seems to be making it even more complex... - Aleix Pol Gonzalez On May 4, 2016, 3:26 p.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127829/ > ----------------------------------------------------------- > > (Updated May 4, 2016, 3:26 p.m.) > > > Review request for KDE Frameworks and Martin Klapetek. > > > Bugs: 337276 > https://bugs.kde.org/show_bug.cgi?id=337276 > > > Repository: knotifyconfig > > > Description > ------- > > QUrl() would treats it as a parsable uri, but they aren't e.g. # in a uri > separates segments in a local file path it simply is a #. > This "accidentally" worked in Phonon < 4.9 as Phonon obtained string > representations in a way that would bypass internal QUrl checks for > fileyness and URI ambiguity. Since 4.9 Phonon expects scheme-less URLs to > be local files, but QUrl() would most of the time not do that since it > would honestly think the soundfilename is a random (i.e. not necessarily > local) uri. > > To fix this use QUrl::fromUserInput which behaves exactly like what we > need to properly resolve relative names, urls, paths, full URIs. > > This now works with input of the type: > - Oxygen-Sys-Special.ogg > - /usr/share/sounds/Oxygen-Sys-Special.ogg > - file:///usr/share/sounds/Oxygen-Sys-Special.ogg > - /usr/share/sounds/#KDE-Im-Cant-#Connect.ogg > - file:///usr/share/sounds/#KDE-Im-Cant-#Connect.ogg > - http://people.ubuntu.com/~apachelogger/sounds/sounds-3.5/KDE_Glass_Break.ogg > (yes, we can have http notifications!!!! https://xkcd.com/1172/) > > CCBUG: 337276 > > > Diffs > ----- > > src/knotifyconfigactionswidget.cpp 98286c4d0e8a7deec5d35986a261222931afb60d > > Diff: https://git.reviewboard.kde.org/r/127829/diff/ > > > Testing > ------- > > built and played all of the above > > > Thanks, > > Harald Sitter > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel