> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg
Well, Ship it is a bit premature. I could not test the patch but: it compiles and code looks sensible. However, there are probably pieces missing. I could spot on, on non-flat toolbuttons (should be in bool Style::drawToolButtonLabelControl, round line 4310 or so, for !flat && hasFocus) Also, did you test if it works for readonly comboboxes ? (possibly this is already covered by pushbuttons). You can probably test this with oxyge-demo/oxygen-demo5 (with style breeze) Finally, oxygen would need a similar patch. I can put it in, but without being yet able to test (I'd need the other updates). So if you have the time and motivation, feel free :) - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127876/#review95312 ----------------------------------------------------------- On May 9, 2016, 3:32 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127876/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 3:32 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: breeze > > > Description > ------- > > with the stylesheet based recoloring for icons, it is possible to make > selected icons the same color as the selected text from the palette. > with the breeze icons style this makes the selected item more readable and > more in line with the style. > > > Diffs > ----- > > kstyle/breezestyle.cpp 403771c > > Diff: https://git.reviewboard.kde.org/r/127876/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > menu.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/cfbb4571-ed40-411e-ad89-453d29fa2610__menu.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
