> On Май 17, 2016, 5:44 след обяд, Martin Gräßlin wrote:
> > src/platforms/xcb/kwindowsystem.cpp, lines 730-732
> > <https://git.reviewboard.kde.org/r/127809/diff/5/?file=464409#file464409line730>
> >
> > this change looks not really needed. Looking at the code I think there
> > is no change at all. Instead of having each segment in if (result.isNull())
> > there is now a if (!result.isNull()) { return result; }
> >
> > That looks pretty much the same, so I think we could just focus on the
> > icon size change.
It's because below you have
if (flags & KWindowSystem::XApp) {
if (result.isNull()) {
So if you have KWindowSystem::XApp setted and result is not Null, this is 2
conditions when you can return with only one. It's a bit of optimization, i can
revert it.
> On Май 17, 2016, 5:44 след обяд, Martin Gräßlin wrote:
> > src/platforms/xcb/kwindowsystem.cpp, line 744
> > <https://git.reviewboard.kde.org/r/127809/diff/5/?file=464409#file464409line744>
> >
> > why 56 - that's not a normal icon size. Maybe 64?
It's not 64 because 48 is not 64/2 so 56-48 = 8, 64-8 = 56 so 56 *equidistance*
between 48 and 64.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127809/#review95540
-----------------------------------------------------------
On Май 6, 2016, 12:08 след обяд, Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127809/
> -----------------------------------------------------------
>
> (Updated Май 6, 2016, 12:08 след обяд)
>
>
> Review request for KDE Frameworks, KDE Usability and Martin Gräßlin.
>
>
> Bugs: 362324
> https://bugs.kde.org/show_bug.cgi?id=362324
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> The api function is KWindowSystem::icon (WId win, int width=-1, int
> height=-1, bool scale=false) so caller must get best size not worst when
> width/height is not specified.
>
>
> Diffs
> -----
>
> src/platforms/xcb/kwindowsystem.cpp 5b7c65a
>
> Diff: https://git.reviewboard.kde.org/r/127809/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> before
>
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png
> after
>
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png
>
>
> Thanks,
>
> Anthony Fieroni
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
