----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127968/ -----------------------------------------------------------
Review request for KDE Frameworks, David Faure and Michael Pyne. Repository: kcoreaddons Description ------- That the & is wrong here is obvious: align can never be 2 inside the if condition as ```(2 & bool)``` is always false, yet the switch on align contains a case for 2. Instead it drops into the while loop for an 4-byte aligned pointer. This doesn't change the returned values on platforms where unaligned reads are permitted, so I didn't bump the version. Diffs ----- src/lib/caching/kshareddatacache.cpp 50bbf64 Diff: https://git.reviewboard.kde.org/r/127968/diff/ Testing ------- Ran make test, all passed. Thanks, Fabian Vogt
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
