----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127973/#review95633 -----------------------------------------------------------
Ship it! I think a comment to the intent would be appropriate (e.g. 'Avoid race in restricting cookie file perms' or something like that) but the change looks correct to me. - Michael Pyne On May 19, 2016, 11:38 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127973/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 11:38 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kinit > > > Description > ------- > > if someone is very fast can watch the file between the open and the > setPermissions > > > Diffs > ----- > > src/kdeinit/kinit.cpp 19e38b8 > > Diff: https://git.reviewboard.kde.org/r/127973/diff/ > > > Testing > ------- > > works > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
