> On May 28, 2016, 12:35 p.m., Kai Uwe Broulik wrote: > > Afaik you can add enum values as long as you don't cause the other's values > > to change or cause the compiler to choose a larger underlying type to fit > > the enum in.
Yes, afaik that is correct. Then my question is: Which is the better fix? Add the dsCount, or add the +1 as in the proposed patch :-) - Dominik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128034/#review95943 ----------------------------------------------------------- On May 28, 2016, 12:32 p.m., Dominik Haumann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128034/ > ----------------------------------------------------------- > > (Updated May 28, 2016, 12:32 p.m.) > > > Review request for Kate and KDE Frameworks. > > > Repository: ktexteditor > > > Description > ------- > > The enum dsError should be included in the count, so we need to add 1. > > With this patch, we are now able to also change the default style "Error" in > the Default styles config page. > > A possible other fix would be to add "dsCount" as last enum entry, and then > just return KTextEditor::dsCount". Would that be a better solution? (and is > adding an enum entry BC?) > > > Diffs > ----- > > src/syntax/katesyntaxmanager.cpp 6d4b80e > > Diff: https://git.reviewboard.kde.org/r/128034/diff/ > > > Testing > ------- > > Works, whereas prior to this patch, I was not able to change the color or any > other attribute of dsError. > > > Thanks, > > Dominik Haumann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
