----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128039/#review96179 -----------------------------------------------------------
(yet another reason for passing parents to widgets rather than making the layout set the parent automatically later) Looks good, but I'm missing a bit of info on what the flag should be set. What does this change in practice? Worth a comment in the code or at least the commit log. - David Faure On May 29, 2016, 6:04 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128039/ > ----------------------------------------------------------- > > (Updated May 29, 2016, 6:04 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kjobwidgets > > > Description > ------- > > The progress widget is a dialog, so we should set the approporiate window > flag. > > > Diffs > ----- > > src/kwidgetjobtracker_p.h 2e5e026 > > Diff: https://git.reviewboard.kde.org/r/128039/diff/ > > > Testing > ------- > > It now has the proper class and is handled appropriately. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
