----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128116/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kconfigwidgets Description ------- This function is intended to return the action for the StandardAction of ShowStatusbar. However, there seems to be an obvious copy/paste error here; the action for ShowMenubar is retrieved instead. This patch corrects this. Diffs ----- src/kstandardaction.cpp 29b7e9b Diff: https://git.reviewboard.kde.org/r/128116/diff/ Testing ------- Built tier3/kconfigwidgets with this change, and tested with an application which looks up the action by name. Without this change there is a segfault because the wrong action is found; with the change the correct action is found and works. The autotest does not detect this problem because it only checks that an action is returned; it doesn't check that it is the correct one! Fixing this would need an extra test of each returned action to check that its name() is correct - not sure whether this is necessary? Thanks, Jonathan Marten
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
