----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127694/#review96376 -----------------------------------------------------------
What projects are wanting to use this? There should be at least two for this to go in ECM. find-modules/FindWaylandProtocols.cmake (line 17) <https://git.reviewboard.kde.org/r/127694/#comment65116> Needs updating now. find-modules/FindWaylandProtocols.cmake (lines 55 - 60) <https://git.reviewboard.kde.org/r/127694/#comment65115> It would be a bit nicer to use the same indenting style found later in the file (ie: put COMMAND on another line, intended 4 spaces, and adjust the other lines to suit). - Alex Merry On May 3, 2016, 10:34 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127694/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 10:34 a.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, and > Alex Merry. > > > Repository: extra-cmake-modules > > > Description > ------- > > WaylandProtocols is a relatively new package containing xml files > of additional stable and unstable protocols. > > By adding a find module projects needing these protocols can depend > on the package instead of needing a copy of the xml in their source > tree. > > > Diffs > ----- > > find-modules/FindWaylandProtocols.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127694/diff/ > > > Testing > ------- > > Added a dependency in KWayland, it was found. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
