----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128187/#review96587 -----------------------------------------------------------
CMakeLists.txt (line 27) <https://git.reviewboard.kde.org/r/128187/#comment65254> can you call the source file qrcAlias.cpp rather than the very generic name main.cpp ? Just in case there are more programs written in this repo one day. CMakeLists.txt (line 49) <https://git.reviewboard.kde.org/r/128187/#comment65255> (it's curious that there isn't a way to get the full path in one go, but I don't know generator expressions enough to recommend something) Well I guess the first part is CMAKE_CURRENT_BINARY_DIR anyway ;) main.cpp (line 1) <https://git.reviewboard.kde.org/r/128187/#comment65256> Missing copyright header above this line. main.cpp (line 11) <https://git.reviewboard.kde.org/r/128187/#comment65257> .arg() is rather overkill for %1/%2, using + '/' would be simpler/faster. main.cpp (line 28) <https://git.reviewboard.kde.org/r/128187/#comment65258> see above ;) main.cpp (line 29) <https://git.reviewboard.kde.org/r/128187/#comment65261> Recursion? Is there a risk of infinite recursion here? main.cpp (line 35) <https://git.reviewboard.kde.org/r/128187/#comment65259> same + double space main.cpp (line 63) <https://git.reviewboard.kde.org/r/128187/#comment65260> remove one of the two empty lines main.cpp (line 84) <https://git.reviewboard.kde.org/r/128187/#comment65262> Missing a call to parser.setApplicationDescription(...) so people can find out what this tool is about. main.cpp (line 97) <https://git.reviewboard.kde.org/r/128187/#comment65263> probably not useful anymore - David Faure On June 16, 2016, 1:01 p.m., Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128187/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 1:01 p.m.) > > > Review request for KDE Frameworks, Andreas Kainz, David Faure, and Kevin Funk. > > > Repository: breeze-icons > > > Description > ------- > > On windows git converts symbolic links to text files with links to > the actual file. This added application modifies the .qrc to use > aliases for the links. > > This change also adds an option to not install the icons. > > > Diffs > ----- > > CMakeLists.txt 08cd1a0 > icons-dark/CMakeLists.txt 5d7e6f8 > icons/CMakeLists.txt bd4c048 > main.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128187/diff/ > > > Testing > ------- > > Compiled on windows with BINARY_ICONS_RESOURCE and SKIP_INSTALL_ICONS enabled. > > We get the icon .rcc file and the icons where not installed > > > Thanks, > > Kåre Särs > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
