----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128147/#review96847 -----------------------------------------------------------
Ship it! Ship It! - David Faure On June 10, 2016, 12:05 p.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128147/ > ----------------------------------------------------------- > > (Updated June 10, 2016, 12:05 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kemoticons > > > Description > ------- > > this means > - doesn't depend on Glass theme anymore > - doesn't hardcode buildtime paths into tests, making the tests themself > relocatable as they lookup data via qtest helpers at runtime > - allows more precise testing as the isolated test theme can be mangled > to our liking > - makes tests pass without running make install first > - by switching both tests cases' qstandardpaths into testing mode we > won't accidentally use data that we didn't intend to test on > - changes to production themes will not break test assumptions > > also introduce an AutoTestBase class to derive for both testcases as we > now have need for a joint copyTheme method which grabs the test data and > dumps it at the desired target path > > > Diffs > ----- > > autotests/CMakeLists.txt dd136da51e47b6c6f33bfcef3d52abf88aac90ee > autotests/autotestbase.h PRE-CREATION > autotests/default-testtheme/angry.png PRE-CREATION > autotests/default-testtheme/confused.png PRE-CREATION > autotests/default-testtheme/dog.png PRE-CREATION > autotests/default-testtheme/emoticons.xml PRE-CREATION > autotests/default-testtheme/sad.png PRE-CREATION > autotests/default-testtheme/smile.png PRE-CREATION > autotests/default-testtheme/tongue.png PRE-CREATION > autotests/kemoticontest.cpp fdada9dfdaf9938e48f86face8e60c853ba54da3 > autotests/ktexttohtmlplugintest.cpp > 9326430f0a4e6545c4507ec9b4dfe64414dd0e4b > > Diff: https://git.reviewboard.kde.org/r/128147/diff/ > > > Testing > ------- > > make && test && install => all good > > > Thanks, > > Harald Sitter > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel