----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128309/#review96935 -----------------------------------------------------------
Can we perhaps make this API a bit more high-level by adding a dedicated DetailsButton class? You're basically just creating a button with a label "Details >>" but the functionality for changing it to << on expanding and what not is still up to the user? src/kmessagebox.cpp (line 1159) <https://git.reviewboard.kde.org/r/128309/#comment65509> While at it, avoid word-puzzle - Kai Uwe Broulik On Juni 28, 2016, 6:16 nachm., Rolf Eike Beer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128309/ > ----------------------------------------------------------- > > (Updated Juni 28, 2016, 6:16 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kwidgetsaddons > > > Description > ------- > > Otherwise an application that wishes to use the details member e.g. of > createKMessageBox() has to duplicate the setup code, including the > translation setup. > > > Diffs > ----- > > src/kmessagebox.h 3826a46 > src/kmessagebox.cpp 194ffae > > Diff: https://git.reviewboard.kde.org/r/128309/diff/ > > > Testing > ------- > > > Thanks, > > Rolf Eike Beer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel