> On July 3, 2016, 8:25 p.m., David Faure wrote: > > autotests/karchivetest.cpp, line 1118 > > <https://git.reviewboard.kde.org/r/128353/diff/1/?file=470950#file470950line1118> > > > > Why QLatin1String("") and not just QString() ?
Previous unit test does the same - Sune ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/#review97066 ----------------------------------------------------------- On July 4, 2016, 6:27 p.m., Sune Vuorela wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128353/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 6:27 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: karchive > > > Description > ------- > > Add unit test to prevent later changes to abandon directory permissions in > zip files > > Test file created with > mkdir ziptest > cd ziptest > mkdir 700 750 755 > chmod 700 700 > chmod 750 750 > chmod 755 755 > zip -r my.zip 7* > > > Diffs > ----- > > autotests/karchivetest.h 5a6375c > autotests/karchivetest.cpp dd03dac > > Diff: https://git.reviewboard.kde.org/r/128353/diff/ > > > Testing > ------- > > > Thanks, > > Sune Vuorela > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel