----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97249 -----------------------------------------------------------
I don't see the point of this change. From a user perspective a user knowing what a hash is know how to use context menu to reach this panel and should be educated enought to know the copy/paste shortcuts. For me it is more interesting that when cliking on text it would select the whole hash text. - Michel Hermier On juil. 9, 2016, 7:55 après-midi, Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128413/ > ----------------------------------------------------------- > > (Updated juil. 9, 2016, 7:55 après-midi) > > > Review request for KDE Frameworks, KDE Usability and David Faure. > > > Repository: kio > > > Description > ------- > > As discussed in RR 128283, we can improve the usability of the dialog if we > add buttons to interact with the clipboard. > > The Paste button is always visible, while the three Copy buttons are hidden > until the correspoding checksum is computed. > > > Diffs > ----- > > src/widgets/checksumswidget.ui 03c64db > src/widgets/kpropertiesdialog.cpp 808765c > > Diff: https://git.reviewboard.kde.org/r/128413/diff/ > > > Testing > ------- > > Copy/Paste works as expected. > > > File Attachments > ---------------- > > Paste button next to the input field. > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/906d90f6-7727-4163-9992-c688667073ec__Spectacle.J11500.png > Example of Copy button > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/10c18534-0e72-4c8c-98ae-144a909438c9__Spectacle.J11519.png > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
