-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128501/
-----------------------------------------------------------
(Updated July 22, 2016, 4:53 p.m.)
Review request for KDE Frameworks and David Faure.
Bugs: 363673
https://bugs.kde.org/show_bug.cgi?id=363673
Repository: kio
Description
-------
Fix for the bug https://bugs.kde.org/show_bug.cgi?id=363673 . The bug occurs
because KPropertiesDialog is initialized (inside
KNewFileMenuPrivate::executeOtherDesktopFile) with path of a resource file. Now
KPropertiesDialog only show properties if the file is a local file(i guess).
Thats why clicking on "Link to Application" and then clicking 'ok' shows an
error message . To Fix this i used QTemporaryFile to copy the contents of the
application template shipped with kio and then initialize KPropertiesDialog
with the temporary files' path.
(I added KNewFileMenuPrivate::mostLocalUrl here to ensure new filename is
suggested when inside "desktop:/".)
(The temporary file created here must be deleted so i also added QFile::remove
to _k_slotOtherDesktopFile and _k_slotAbortDialog so that whether or not the
user creates a Link to Application, the temporary is always deleted)
Diffs (updated)
-----
src/filewidgets/knewfilemenu.h 4543eb7
src/filewidgets/knewfilemenu.cpp 7374417
Diff: https://git.reviewboard.kde.org/r/128501/diff/
Testing
-------
Thanks,
Chinmoy Ranjan Pradhan
_______________________________________________
Kde-frameworks-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
