----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/#review98004 -----------------------------------------------------------
Ship it! He, this is the very same patch that I found in the fork/copy of KDescendantsProxyModel in the sources of Marble when I updated it to latest KF5 version. Actually that patch there was done in 2012 but seems it never got upstreamed, can someone please fix the (L)GPL to require patches to be at least reported to upstream!1! Meh. I cannot remember what bugged me about this very code when I tried to reason why it fixes things that I went instead for the version in https://git.reviewboard.kde.org/r/128398/ But as said in the comment there, I have not had grasped the complete logic and hoped for guidance by Stephen :) So given this patch here completes the autotests, also matches that previous patch found in Marble and still works fine in Marble, it has my "Ship it" :) Thanks for picking this up and getting to a proper test and seemingly better fix, Sune & David. - Friedrich W. H. Kossebau On July 24, 2016, 9:14 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128515/ > ----------------------------------------------------------- > > (Updated July 24, 2016, 9:14 p.m.) > > > Review request for KDE Frameworks, Friedrich W. H. Kossebau, Stephen Kelly, > and Sune Vuorela. > > > Repository: kitemmodels > > > Description > ------- > > This fixes Sune's unittest. > > > Diffs > ----- > > autotests/kdescendantsproxymodeltest.cpp > 67c0fba5bdcf700659889731f80043911af211fb > src/kdescendantsproxymodel.cpp 477cd961e57bd8d8863f543aac1c7ac806bff24c > > Diff: https://git.reviewboard.kde.org/r/128515/diff/ > > > Testing > ------- > > Just the unittest. > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
