> On Aug. 3, 2016, 5:26 a.m., Kevin Ottens wrote: > > You also tested with kmessageboxtest, right?
Yes, though being a manual test it's always a bit hard to know if it's working, it seems to be fine imho. > On Aug. 3, 2016, 5:26 a.m., Kevin Ottens wrote: > > src/kmessagebox_p.cpp, line 94 > > <https://git.reviewboard.kde.org/r/128581/diff/1/?file=472785#file472785line94> > > > > Might be a somewhat common scenario, I'm not sure we want to issue a > > warning unconditionally. It's not common at all, https://lxr.kde.org/search?_filestring=&_string=setDontShowAgainConfig And if it was, more reason to tell people whatever they're trying to do isn't working. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128581/#review98034 ----------------------------------------------------------- On Aug. 2, 2016, 10:27 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128581/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 10:27 p.m.) > > > Review request for KDE Frameworks, Christoph Feck, David Faure, and Kevin > Ottens. > > > Repository: kwidgetsaddons > > > Description > ------- > > Otherwise if you don't have the framework integration plugin installed, the > messageboxes appear again and again and again even if the user continuously > clicks "Don't show again". > > See "KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it > useless" thread in kde-frameworks-devel mailing list for more information. > > > Diffs > ----- > > src/kmessagebox_p.cpp 896cdb7 > > Diff: https://git.reviewboard.kde.org/r/128581/diff/ > > > Testing > ------- > > Tried rsibreak without the framework integration plugin, worked. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
