----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128638/#review98251 -----------------------------------------------------------
Ship it! It's useful when copying stuff around to use `git diff --find-copies-harder` so moves are actual moves rather than destruction + creation. - Aleix Pol Gonzalez On Aug. 9, 2016, 9:14 p.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128638/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2016, 9:14 p.m.) > > > Review request for KDE Frameworks, Localization and Translation (l10n) and > David Faure. > > > Repository: kwallet > > > Description > ------- > > move docbook into subdit with matching name in l10n subdir + adapt > docs/CMakeLists.txt > > Rationale: > > The Translated docbooks in this frameworks are missing in the tarball, see > https://todo.kde.org/?controller=task&action=show&task_id=520 > > To find out which subdir of docs/frameworks subdir it should grab translated > docs from, the frameworks release script uses the name of the subdir in the > sources. > > On the other hand the script autogen.sh in l10n-kf5/scripts generates the > CMakeLists.txt files > with the correct install paths/names for the language docbooks using the > dirnames in l10n/[lang]/documentation. > > > Diffs > ----- > > docs/CMakeLists.txt c4ef9c7 > docs/kwallet-query/CMakeLists.txt PRE-CREATION > docs/kwallet-query/man-kwallet-query.1.docbook PRE-CREATION > docs/kwallet-query/using.adoc PRE-CREATION > docs/man-kwallet-query.1.docbook eed6e43 > docs/using.adoc e2e01e4 > > Diff: https://git.reviewboard.kde.org/r/128638/diff/ > > > Testing > ------- > > builds and installs the manpage to the same dir as before > > > Thanks, > > Burkhard Lück > >
