----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128796/#review98771 -----------------------------------------------------------
src/core/slavebase.cpp (line 465) <https://git.reviewboard.kde.org/r/128796/#comment66505> It would be useful to mention the name of the slave here, so people don't report generic KIO bugs due to this warning ;-) src/core/slavebase.cpp (line 691) <https://git.reviewboard.kde.org/r/128796/#comment66507> Note that your new code won't be triggered in this case --- but OK, this is deprecated API so *hopefully* slaves are moving away from it. src/core/slavebase.cpp (line 703) <https://git.reviewboard.kde.org/r/128796/#comment66506> Shouldn't it be set to false again at the beginning of the next listDir? Maybe the slave emits "." for some directories and not for others... - David Faure On Aug. 29, 2016, 1:36 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128796/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2016, 1:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 366795 > https://bugs.kde.org/show_bug.cgi?id=366795 > > > Repository: kio > > > Description > ------- > > Since there are too many slaves that don't (or > [can't](https://bugs.kde.org/show_bug.cgi?id=367878#c3), in the kdeconnect > case) emit an UDSEntry for ".", we can provide a fallback in the SlaveBase > class. > > > Diffs > ----- > > src/core/slavebase.cpp f939146 > > Diff: https://git.reviewboard.kde.org/r/128796/diff/ > > > Testing > ------- > > Paste action is enabled again for mtp:// and kdeconnect:// slaves. > > > Thanks, > > Elvis Angelaccio > >
