----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128814/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: attica Description ------- Attica uses Qt5Network in its public API, so it must declare it as a public dependency otherwise consumers could fail to build if Qt5Network is not already found elsewhere in the dependency tree. Diffs ----- KF5AtticaConfig.cmake.in 078d03c416316fc446b40405cb35f23665f5ed86 Diff: https://git.reviewboard.kde.org/r/128814/diff/ Testing ------- Consider this test case: ```cmake project(test) find_package(ECM 1.7.0 REQUIRED NO_MODULE) find_package(KF5Attica REQUIRED) set(test_SRCS test.cpp) add_executable(test ${test_SRCS}) target_link_libraries(test KF5::Attica) ``` Before the change it fails to build with ``ld: cannot find -lQt5::Network``, after the change it passes. Thanks, Michael Palimaka
