----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/#review98963 -----------------------------------------------------------
cmake/FindUTEMPTER.cmake (line 35) <https://git.reviewboard.kde.org/r/128790/#comment66626> this is not necessary any more unless you use it to compute a possible search path cmake/FindUTEMPTER.cmake (line 37) <https://git.reviewboard.kde.org/r/128790/#comment66625> remove this and the respective link line src/kpty.cpp (line 28) <https://git.reviewboard.kde.org/r/128790/#comment66624> dead include - Oswald Buddenhagen On Sept. 4, 2016, 10:20 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128790/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2016, 10:20 a.m.) > > > Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Oswald > Buddenhagen, Rex Dieter, and Thiago Macieira. > > > Bugs: 364779 > https://bugs.kde.org/show_bug.cgi?id=364779 > > > Repository: kpty > > > Description > ------- > > According to the investigation in https://bugs.kde.org/show_bug.cgi?id=364779 > utempter does stuff in a way that isn't compatible with > QProcess/KProcess/KPtyProcess (calling sigaction() before launching its child > process). > > So instead we invoke it manually with QProcess. > > > Diffs > ----- > > cmake/FindUTEMPTER.cmake a3ea06a > src/kpty.cpp 15c3b81 > src/kpty_p.h 192bf1c > > Diff: https://git.reviewboard.kde.org/r/128790/diff/ > > > Testing > ------- > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
