-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128759/
-----------------------------------------------------------
(Updated Sept. 7, 2016, 7:05 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
-------
Submitted with commit 8d9befe7c9f7813352ddb4b6a1c169f31e5f5365 by Elvis
Angelaccio to branch master.
Bugs: 366075
https://bugs.kde.org/show_bug.cgi?id=366075
Repository: kio
Description
-------
Dolphin sets a F10 shortcut to create new folders, but this shortcut doesn't
show up near the action. This happens because the action is created by
KNewFileMenu which doesn't know about the shortcut. Since we pass an action
collection to KNewFileMenu, this issue can be easily fixed by looking up a
fixed action key (e.g. `create_dir`, already used by Dolphin) and assuming that
the client code sets a shortcut for this action.
We just need to keep track whether we find such an action in the action
collection (otherwise "New -> Folder..." in Dolphin opens the dialog twice).
Diffs
-----
src/filewidgets/knewfilemenu.h dfc808b
src/filewidgets/knewfilemenu.cpp a340429
Diff: https://git.reviewboard.kde.org/r/128759/diff/
Testing
-------
Make sure that "New -> Folder" shows F10 as shortcut in Dolphin.
Make sure that triggering the action doesn't show the dialog twice.
Thanks,
Elvis Angelaccio
