----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128887/#review99092 -----------------------------------------------------------
Looks good to me. I would though appreciate a unit test if ever possible. It would be an easy bug to reintroduce. - Sune Vuorela On Sept. 11, 2016, 11:49 a.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128887/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2016, 11:49 a.m.) > > > Review request for KDE Frameworks. > > > Repository: baloo > > > Description > ------- > > Fix that baloo is instant killed by any file with timestamp 0. (which is OK > and can easily happen after unpacking some zip/tar/..) > > Bug 355238 > https://bugs.kde.org/show_bug.cgi?id=355238 > > > Diffs > ----- > > src/engine/documenttimedb.cpp aa0925a > src/engine/writetransaction.cpp 9ad7520 > > Diff: https://git.reviewboard.kde.org/r/128887/diff/ > > > Testing > ------- > > > Thanks, > > Christoph Cullmann > >