-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99246
-----------------------------------------------------------



I do not understand the bug report you linked to.

After applying rev 2 of this patch, I see that KMessageBox uses a scrollbar 
because the message text is really long, and after clicking the Details button, 
those are correctly shown.

What is the actual bug you are trying to fix?

- Christoph Feck


On Sept. 18, 2016, 4 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366569
>     https://bugs.kde.org/show_bug.cgi?id=366569
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Hi David,
> 
> K3B use KMessageBox::detailedSorry to show message for not support protocol 
> such as add files from samba, but KMessageBox::detailedSorry hide some part 
> of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is 
> better to show it directly by default!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   tests/kmessageboxtest.cpp 8ea2848 
> 
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
> 
> 
> Testing
> -------
> 
> add case 26 in the patch, for long (> 512) details:
> 
> kwidgetsaddons/build/tests/kmessageboxtest 26
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

Reply via email to