-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128958/#review99315
-----------------------------------------------------------



Please submit this into upstread shared-mime-info instead [or possibly in 
addition], see https://www.freedesktop.org/wiki/Specifications/AddingMIMETutor/

I can approve it upstream.

- David Faure


On Sept. 20, 2016, 11:59 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128958/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 11:59 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> This adds a mime type for .ovpn files used for configuring OpenVPN clients.
> 
> 
> Diffs
> -----
> 
>   src/mimetypes/kde5.xml 81ec9a7 
> 
> Diff: https://git.reviewboard.kde.org/r/128958/diff/
> 
> 
> Testing
> -------
> 
> I can now click a file and have plasma-nm's connection editor import it.
> 
> Not sure about the magic, "client" is all I could find which isn't very 
> descriptive, so perhaps better to just look for *.ovpn (I have also seen 
> *.openvpn but *.ovpn seems more common)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Reply via email to