> On Sept. 22, 2016, 9:12 nachm., David Faure wrote:
> > src/kcrash.cpp, line 62
> > <https://git.reviewboard.kde.org/r/128988/diff/1/?file=477287#file477287line62>
> >
> >     While you're here, this should now be QtInfoMsg, see 413eb26 in ECM (or 
> > review 128232).

I'd rather put that in a separate commit.
Also, I've seen that in quite a number of other frameworks. Should I mail 
kde-frameworks one time instead of posting another round of review requests?


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/#review99438
-----------------------------------------------------------


On Sept. 21, 2016, 7:11 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128988/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 7:11 nachm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcrash
> 
> 
> Description
> -------
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -----
> 
>   src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 
> 
> Diff: https://git.reviewboard.kde.org/r/128988/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Reply via email to