----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128437/#review99619 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Sept. 28, 2016, 10:36 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128437/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 10:36 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kcrash > > > Description > ------- > > with the rise of useful core dump handlers such as systemd's coredump and > ubuntu's apport it is no longer useful to handle things exclusively in > drkonqi. it bypasses sysadmins as well as distros in debugging efforts, > putting the entire flow of information on us. > > the new behavior instead checks if a core pattern executable is set and if > so re-raises the signal so the kernel jumps in and invokes the handler. > > (this unfortunately means that the core will contain our kcrash frames, > but that seems hardly avoidable) > > > Diffs > ----- > > CMakeLists.txt 21ccd1df72f6ab2e60bb3f8f9212359f1c24c53f > autotests/CMakeLists.txt e442520269835df71968bf7818aa34bd8bd945cf > autotests/core_patterns/exec PRE-CREATION > autotests/core_patterns/no-exec PRE-CREATION > autotests/coreconfigtest.cpp PRE-CREATION > src/CMakeLists.txt e733be69c6ca6e6c1a0608c8910cf4a9b52ffcc9 > src/config-kcrash.h.cmake f1b3a9babda3e2220aed3c19b735f90eb1ea8e7e > src/coreconfig.cpp PRE-CREATION > src/coreconfig_p.h PRE-CREATION > src/kcrash.cpp d9acb591edb2232db6c9e0dc2726cf0f189823a0 > > Diff: https://git.reviewboard.kde.org/r/128437/diff/ > > > Testing > ------- > > builds and passes > > > Thanks, > > Harald Sitter > >
