----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/#review99835 -----------------------------------------------------------
src/plasma/applet.cpp (lines 96 - 97) <https://git.reviewboard.kde.org/r/129102/#comment67094> Whilst this change looks sensible, it's not related. src/plasma/pluginloader.cpp <https://git.reviewboard.kde.org/r/129102/#comment67096> This code path effectively breaks the the custom loader. - David Edmundson On Oct. 5, 2016, 2:18 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129102/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 2:18 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Makes it possible to use plugins that offer a metadata.json file. > Define the service type when falling back to the desktop file parser, so the > type system is proper. > Don't destroy a KPluginMetadata tuple to instanciate it right away. > > > Diffs > ----- > > src/plasma/applet.cpp 5eb529c > src/plasma/containment.h 0b7a3ef > src/plasma/containment.cpp 1840f24 > src/plasma/pluginloader.h 566461d > src/plasma/pluginloader.cpp db2b2c9 > src/plasma/private/applet_p.cpp fafb450 > > Diff: https://git.reviewboard.kde.org/r/129102/diff/ > > > Testing > ------- > > Tests still pass, plasma still loads, even with RR #129103. > > > Thanks, > > Aleix Pol Gonzalez > >
