> On Oct. 8, 2016, 3:13 p.m., David Faure wrote: > > This seems like a reverse dependency to me, kwallet (a framework) depending > > on kde/pim/gpgmepp. > > Is it planned to turn gpgmepp into a framework? > > If yes, then let's do that. > > If no, then 1) it's wrongly named, the pim people have been abusing the KF5 > > prefix for things that are not framework > > and 2) kwallet can't depend on it.
Well, this is the status quo. ;) kwallet so far was optionally able to use KF5Gpgmepp, but this has now moved into GpgME, which the review addresses: https://mail.kde.org/pipermail/release-team/2016-September/009732.html - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129071/#review99851 ----------------------------------------------------------- On Sept. 29, 2016, 11:32 a.m., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129071/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 11:32 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kwallet > > > Description > ------- > > If Gpgmepp is not found, try to use KF5Gpgmepp > > > Diffs > ----- > > src/runtime/kwalletd/CMakeLists.txt > d7e9ca2c9891db811ecf7063d15f829cf34ad52b > src/runtime/kwalletd/backend/CMakeLists.txt > 20bd4d95c3c1b0cfa43cbe71ce73fa699515ecfa > tests/kwalletd/CMakeLists.txt c84c1db6003412b6a7ac2768f171cbab380b376c > > Diff: https://git.reviewboard.kde.org/r/129071/diff/ > > > Testing > ------- > > Builds and links fine with either GpgME-1.7.0 or KF5Gpgmepp present. > > > Thanks, > > Andreas Sturmlechner > >