-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129172/#review99983
-----------------------------------------------------------


Ship it!




As an advanced user I liked the temp-looking filename, it was telling me that 
the kioexec-trick was in operation, but OK, for end users this is nicer ;)

- David Faure


On Oct. 13, 2016, 12:38 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129172/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2016, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> kioexec currently creates temp files using the following filename scheme: 
> `<pid>_<counter>_<filename>`. So users get a filename different from what 
> they expected (just the filename, without random numbers).
> 
> This patch moves the pid and counter numbers in a folder that contains the 
> temp file (with the origin filename). On cleanup, we make sure to delete also 
> this folder.
> 
> 
> Diffs
> -----
> 
>   src/kioexec/main.cpp 0a5352ebb91ab0b29bfdf97f3b234dbb01c162fe 
> 
> Diff: https://git.reviewboard.kde.org/r/129172/diff/
> 
> 
> Testing
> -------
> 
> * Open a remote url with a non-kio app, e.g. a gdrive:// Google Doc file with 
> Libreoffice.
> * Check the filename in the app window title.
> * Check that temp file and folder (in .cache/kioexec/krun) are deleted after 
> the 3 minutes delay.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Reply via email to