-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129162/#review99985
-----------------------------------------------------------



I hope your commit log has a better description than "?" :-)


autotests/kfilewidgettest.cpp (line 62)
<https://git.reviewboard.kde.org/r/129162/#comment67140>

    Not very Windows-friendly; maybe use QDir::homePath()?



autotests/kfilewidgettest.cpp (line 72)
<https://git.reviewboard.kde.org/r/129162/#comment67141>

    ... and QDir::tempPath()



src/filewidgets/kfilewidget.cpp (line 1522)
<https://git.reviewboard.kde.org/r/129162/#comment67142>

    it's => its



src/filewidgets/kfilewidget.cpp (line 1523)
<https://git.reviewboard.kde.org/r/129162/#comment67143>

    Just wondering, would the second part of the if() be enough on its own?


- David Faure


On Oct. 12, 2016, 6:41 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129162/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 6:41 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> ?
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 2deb367 
>   autotests/kfilewidgettest.cpp PRE-CREATION 
>   src/filewidgets/kfilewidget.cpp 088aa79 
> 
> Diff: https://git.reviewboard.kde.org/r/129162/diff/
> 
> 
> Testing
> -------
> 
> See the test, testFocusOnLocationEditChangeDir2 passes both with and without 
> the patch but testFocusOnLocationEditChangeDir does not, and they basically 
> do the same just in a different order.
> 
> Also kate + Ctrl+O now does correctly focus on the "name" lineedit the first 
> time instead of on the kdiroperator
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Reply via email to