> On oct. 13, 2016, 5:16 p.m., David Faure wrote:
> > I hope your commit log has a better description than "?" :-)

The title should be good enough, the desciprtion was supposed to be two arrows 
pointing up, i guess something got messed up :D


> On oct. 13, 2016, 5:16 p.m., David Faure wrote:
> > autotests/kfilewidgettest.cpp, line 62
> > <https://git.reviewboard.kde.org/r/129162/diff/1/?file=482044#file482044line62>
> >
> >     Not very Windows-friendly; maybe use QDir::homePath()?

Fix, i'll try to use that.


> On oct. 13, 2016, 5:16 p.m., David Faure wrote:
> > src/filewidgets/kfilewidget.cpp, line 1522
> > <https://git.reviewboard.kde.org/r/129162/diff/1/?file=482045#file482045line1522>
> >
> >     it's => its

yep


> On oct. 13, 2016, 5:16 p.m., David Faure wrote:
> > src/filewidgets/kfilewidget.cpp, line 1523
> > <https://git.reviewboard.kde.org/r/129162/diff/1/?file=482045#file482045line1523>
> >
> >     Just wondering, would the second part of the if() be enough on its own?

Most probably, just wanted to play it on the safe side, but if you prefer i can 
remove the first part.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129162/#review99985
-----------------------------------------------------------


On oct. 12, 2016, 6:41 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129162/
> -----------------------------------------------------------
> 
> (Updated oct. 12, 2016, 6:41 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> ?
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 2deb367 
>   autotests/kfilewidgettest.cpp PRE-CREATION 
>   src/filewidgets/kfilewidget.cpp 088aa79 
> 
> Diff: https://git.reviewboard.kde.org/r/129162/diff/
> 
> 
> Testing
> -------
> 
> See the test, testFocusOnLocationEditChangeDir2 passes both with and without 
> the patch but testFocusOnLocationEditChangeDir does not, and they basically 
> do the same just in a different order.
> 
> Also kate + Ctrl+O now does correctly focus on the "name" lineedit the first 
> time instead of on the kdiroperator
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Reply via email to