-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129173/#review100018
-----------------------------------------------------------



+1, seems obvious to me, although I didn't know this code.

- David Faure


On Oct. 13, 2016, 4:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129173/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2016, 4:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> Was tracking down a bug, noticed something (unrelated) wrong.
> 
> The disableAutostart property is only in one of the two code paths.
> Disabling debug should not have an effect on the behaviour of the
> application.
> 
> This patch puts the same logic (the more common debug enabled branch) in both 
> code paths.
> 
> 
> Diffs
> -----
> 
>   src/lib/manager_p.cpp 9d7c9f952dab1ab3df2045bcad1775d7dd962256 
> 
> Diff: https://git.reviewboard.kde.org/r/129173/diff/
> 
> 
> Testing
> -------
> 
> Logged out, logged in. All started fine.
> 
> (though I don't understand why you have a no QT_DEBUG branch when using 
> categorised logging anyway? )
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Reply via email to