> On Oct. 16, 2016, 2:38 p.m., Aleix Pol Gonzalez wrote:
> > src/kconfig_compiler/README.dox, line 216
> > <https://git.reviewboard.kde.org/r/129188/diff/2/?file=482239#file482239line216>
> >
> >     Are you sure this is needed? maybe we could make it so it's not needed? 
> > Looks the kind of thing that will generate crazy errors, hard to figure out.

It won't compile without (unless I'm doing something wrong). GenerateProperties 
adds "include xxx.moc" in the generated xxx.cpp file, but the compiler doesn't 
find xxx.moc without the GENERATE_MOC option. I don't know exactly how cmake 
handles the moc, but maybe xxx.{h,cpp} are generated after automoc has already 
been run?


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129188/#review100043
-----------------------------------------------------------


On Oct. 15, 2016, 9:31 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129188/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2016, 9:31 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> The `GenerateProperties` option is missing from: 
> https://api.kde.org/frameworks/kconfig/html/kconfig_compiler.html
> 
> This patch explains what the option does and how to use it.
> 
> 
> Diffs
> -----
> 
>   src/kconfig_compiler/README.dox b9606f1d157229a22afbeaea7d56ee95732762a2 
> 
> Diff: https://git.reviewboard.kde.org/r/129188/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Reply via email to