-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129202/#review100066
-----------------------------------------------------------



+1 LGTM, unsure of the implications.

- Aleix Pol Gonzalez


On Oct. 16, 2016, 7:50 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129202/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2016, 7:50 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez, Dan Leinir Turthra 
> Jensen, and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Always mark a provider as initialized when all initializion steps
> are performed, in particularly when an error occured. This ensures
> that the UI is correctly updated when the initialization steps finished.
> 
> 
> Diffs
> -----
> 
>   src/attica/atticaprovider.cpp bc590ce2a2170f69d0b6d8049f7d5da5d0c1d0cd 
> 
> Diff: https://git.reviewboard.kde.org/r/129202/diff/
> 
> 
> Testing
> -------
> 
> manual testing
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

Reply via email to