----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129205/ -----------------------------------------------------------
Review request for KDE Frameworks and David Faure. Repository: kio Description ------- David, i will discard review if you don't like it, cause watching files changes can be *really* expensive. I try to: 1. to not break abi compability 2. to extend filenamesearch with this option 3. to fix https://git.reviewboard.kde.org/r/129141/ Diffs ----- src/core/kcoredirlister.h e6ba2ac src/core/kcoredirlister.cpp 508516e src/core/kcoredirlister_p.h 9a3cc7b Diff: https://git.reviewboard.kde.org/r/129205/diff/ Testing ------- For 3. i still can't figure out why in filenamesearch signal for delete item(s) is not triggered. 1. Search for file (by name) in dolphin 2. When appear in view delete him 3. Signal ItemsDeleted is not triggered, file stays in the view even if new search is performed and reload is needed. The cache look good, tests pass, works but in filenamesearch. Thanks, Anthony Fieroni
