-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129262/
-----------------------------------------------------------

Review request for KDE Frameworks and David Faure.


Bugs: 363936
    https://bugs.kde.org/show_bug.cgi?id=363936


Repository: kio


Description
-------

If the user closes a DndPopupMenu without triggering an action, the DropJob 
never emits the result signal. This results in Dolphin hangs (see bug 363936).

This patch uses a boolean flag to track whether an action has been triggered in 
the job's popup menu.
If the flag is false and the menu gets deleted, we need to manually emit the 
result signal.

QMenu emits `aboutToHide` before `triggered`, so I had to use a QTimer as 
workaround. I'm not sure if there is a better way to do this...


Diffs
-----

  src/widgets/dropjob.cpp f033bfb5318624836d8b83c6783cf998990dcc02 

Diff: https://git.reviewboard.kde.org/r/129262/diff/


Testing
-------

Make sure https://bugs.kde.org/show_bug.cgi?id=363936 is fixed.


Thanks,

Elvis Angelaccio

Reply via email to