----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/#review100331 -----------------------------------------------------------
The problem with isNativeMenuBar() is that it returns true if the window *may* be a native menu bar, for example when the platform theme removes the AA_DontUseNativeMenuBar qApp flag. This does not mean that the platform theme actually created a native menu bar for the window - which ours does not if no global menu service is available. Changing it from checking whether platformMenuBar() returns something fixes this for me and the entry behaves properly, being hidden when global menu is available, and being visible if not. - Kai Uwe Broulik On Okt. 25, 2016, 10:15 nachm., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129261/ > ----------------------------------------------------------- > > (Updated Okt. 25, 2016, 10:15 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kconfigwidgets > > > Description > ------- > > Some applications have a "Show Menu Bar" action that is a bit silly on > systems where the menubar is part of the shell (for example Unity 7). > > This patch attempts to fix it by iterating all the main windows when they are > shown and if all the menubars of all mainwindows are native, then hides the > show menu bar action (basically erasing it from existence). > > It's not the nicest of the codes and probably has some edge cases but works > on the general case so i think it's worth the effort. > > > Diffs > ----- > > src/kstandardaction.cpp 89d011e > > Diff: https://git.reviewboard.kde.org/r/129261/diff/ > > > Testing > ------- > > Tried konsole, kate and dolphin under Unity 7 on Ubuntu 16.10 > > konsole and kate work fine (i.e. the action is gone from the menus and all is > good) > > dolphin is not 100% "perfectly behabed" (i.e. the "control" toolbar item is > supposed to not be shown when menubars are shown and in this case it's shown) > but it's not a regression and imho it's the dolphin code being a bit weird (i > can propose a patch for it if this gets accepted) > > > Thanks, > > Albert Astals Cid > >
