----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129197/#review100148 -----------------------------------------------------------
autotests/kptyprocesstest.cpp (line 123) <https://git.reviewboard.kde.org/r/129197/#comment67266> just use QStandardPaths::findExecutable() anyway, that's for a separate commit. - Oswald Buddenhagen On Oct. 16, 2016, 11:44 a.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129197/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2016, 11:44 a.m.) > > > Review request for KDE Frameworks, Adriaan de Groot, Tobias Berner, Oswald > Buddenhagen, and Martin Tobias Holmedahl Sandsmark. > > > Repository: kpty > > > Description > ------- > > Apparently, KPtyDevice can't be operated on after KPtyProcess finishes. Tweak > tests accordingly, so they actually test things while the process is still > running. > > > Diffs > ----- > > autotests/kptyprocesstest.cpp 8b0b5b0 > > Diff: https://git.reviewboard.kde.org/r/129197/diff/ > > > Testing > ------- > > make test on FreeBSD > > > Thanks, > > Gleb Popov > >
