> On Oct. 30, 2016, 2:22 p.m., Christoph Feck wrote: > > src/kcursor_p.h, line 46 > > <https://git.reviewboard.kde.org/r/129283/diff/1/?file=483327#file483327line46> > > > > Do we remove the "virtual" keyword? Or would that mean that subclasses > > can no longer override?
Personally, I would remove it, since it's redundant, and only adds noise I have to read. And no, once a function is virtual it'll stay virtual. - Dominik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129283/#review100403 ----------------------------------------------------------- On Oct. 30, 2016, 1:33 p.m., Allen Winter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129283/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2016, 1:33 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kwidgetsaddons > > > Description > ------- > > Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override > > > Diffs > ----- > > src/kacceleratormanager_p.h 55ab1c1 > src/kcharselect_p.h e4efdab > src/kcharselectdata.cpp 92c1c79 > src/kcursor_p.h fcac8d9 > src/kfontaction.h ae84944 > src/kmultitabbar.h 79e62ed > src/kmultitabbar_p.h 6311413 > src/kurllabel.h eeba9e0 > > Diff: https://git.reviewboard.kde.org/r/129283/diff/ > > > Testing > ------- > > all warnings for -Wsuggest-override are gone > make test still passes > > > Thanks, > > Allen Winter > >
