----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129302/#review100459 -----------------------------------------------------------
Ship it! Not only generictypes.h includes NM headers, they are used in many places. - Jan Grulich On Lis. 1, 2016, 8:24 dop., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129302/ > ----------------------------------------------------------- > > (Updated Lis. 1, 2016, 8:24 dop.) > > > Review request for KDE Frameworks and Jan Grulich. > > > Repository: networkmanager-qt > > > Description > ------- > > Currently the pri file has Qt.NetworkManagerQt.includes = > /usr/include/NetworkManagerQt. > This changes fixes it and makes it /usr/include/KF5/NetworkManagerQt > > > Diffs > ----- > > src/CMakeLists.txt 3249154 > > Diff: https://git.reviewboard.kde.org/r/129302/diff/ > > > Testing > ------- > > Correct include paths when used from qmake. > It still cannot be used from qmake without additional changes because > `generictypes.h` includes `nm-version.h` from libnm which is not in include > paths. > > > Thanks, > > David Rosca > >
